Fix parsing of "Reviewed By" field
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 10:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 9:56 PM

	Unknown Object (File)
	Tue, Apr 23, 4:07 AM

	Unknown Object (File)
	Sun, Apr 21, 4:20 PM

	Unknown Object (File)
	Fri, Apr 19, 8:51 PM

	Unknown Object (File)
	Fri, Apr 19, 8:51 PM

	Unknown Object (File)
	Fri, Apr 19, 7:32 PM

	Unknown Object (File)
	Tue, Apr 9, 5:25 PM

	Unknown Object (File)
	Fri, Apr 5, 2:07 PM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP8a409aa40fe0: Fix parsing of "Reviewed By" field

Summary

In the Message parser, we read this field and expect to get an array of PHIDs out of it. Currently, we get a string. Instead, get an array of PHIDs.

Test Plan

Wrote a message like "Fixes Tnnn" with "Reviewed by: duck", and saw no more parse error during message parsing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20190.Mar 12 2014, 10:50 PM

epriestley retitled this revision from to Fix parsing of "Reviewed By" field.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added subscribers: epriestley, aran.Mar 12 2014, 10:50 PM

btrahan accepted this revision.Mar 13 2014, 12:57 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 13 2014, 12:57 AM

Closed by commit rP8a409aa40fe0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialCustomField.php

6 lines

DifferentialReviewedByField.php

10 lines

Diff 20198

View Options

src/applications/differential/customfield/DifferentialCustomField.php