Page MenuHomePhabricator
Files F13174473

D12996.id.diff
No OneTemporary
Actions

D12996.id.diff
View Options

diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php
--- a/src/applications/differential/parser/DifferentialChangesetParser.php
+++ b/src/applications/differential/parser/DifferentialChangesetParser.php
@@ -906,11 +906,10 @@
$shield = $renderer->renderShield(
pht('This file was completely deleted.'));
} else if ($this->changeset->getAffectedLineCount() > 2500) {
- $lines = number_format($this->changeset->getAffectedLineCount());
$shield = $renderer->renderShield(
pht(
'This file has a very large number of changes (%s lines).',
- $lines));
+ new PhutilNumber($this->changeset->getAffectedLineCount())));
}
}
diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -240,10 +240,10 @@
$change_panel = new PHUIObjectBoxView();
$header = new PHUIHeaderView();
- $header->setHeader(pht('Changes (%d', number_format($count)));
+ $header->setHeader(pht('Changes (%s)', new PhutilNumber($count)));
$change_panel->setID('toc');
- if ($count > self::CHANGES_LIMIT && !$show_all_details) {
+ if ($count > self::CHANGES_LIMIT && !$show_all_details) {
$icon = id(new PHUIIconView())
->setIconFont('fa-files-o');
diff --git a/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php b/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
--- a/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
+++ b/src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
@@ -241,8 +241,8 @@
'**NOTE**: This script will queue tasks to reparse the data. Once the '.
'tasks have been queued, you need to run Taskmaster daemons to '.
'execute them.'."\n\n".
- "QUEUEING TASKS (%d Commits):",
- number_format(count($commits))));
+ "QUEUEING TASKS (%s Commits):",
+ new PhutilNumber(count($commits))));
}
$progress = new PhutilConsoleProgressBar();

File Metadata

Mime Type
text/plain
Expires
Wed, May 8, 11:21 PM (2 w, 4 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6267554
Default Alt Text
D12996.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility