Page MenuHomePhabricator
Differential D9969

Tidy paths for `require_once`
ClosedPublic
Actions

Authored by joshuaspence on Jul 17 2014, 11:28 PM.
Tags
None
Referenced Files
F15456678: D9969.id23955.diff
Sun, Mar 30, 11:19 AM
F15447979: D9969.id23955.diff
Fri, Mar 28, 2:39 AM
F15429150: D9969.diff
Mon, Mar 24, 12:57 AM
F15411591: D9969.id23955.diff
Wed, Mar 19, 9:28 AM
F15411506: D9969.id23956.diff
Wed, Mar 19, 9:21 AM
F15404149: D9969.id.diff
Tue, Mar 18, 6:28 AM
F15402384: D9969.diff
Mon, Mar 17, 10:15 PM
F15401935: D9969.id23956.diff
Mon, Mar 17, 7:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU25ca8b37655d: Tidy paths for `require_once`
Summary

Use .. instead of dirname(). I think that this is much neater.

Test Plan

Ran all of the affected scripts.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23955.Jul 17 2014, 11:28 PM
joshuaspence retitled this revision from to Tidy paths for `require_once`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2014, 11:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1755: Diff 23955.Jul 17 2014, 11:29 PM
epriestley accepted this revision.Jul 17 2014, 11:32 PM
epriestley edited edge metadata.

sure

This revision is now accepted and ready to land.Jul 17 2014, 11:32 PM
joshuaspence closed this revision.Jul 17 2014, 11:32 PM
joshuaspence updated this revision to Diff 23956.

Closed by commit rPHU25ca8b37655d (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
scripts/
daemon/
exec/
3 lines
sandpit/
2 lines
test/
3 lines
19 lines
3 lines
7 lines
5 lines
3 lines
3 lines
3 lines
3 lines
utils/
2 lines
2 lines
support/
parser/
3 lines

Diff 23956

View Options

scripts/daemon/exec/exec_daemon.php

Loading...
View Options

scripts/sandpit/harden_directory.php

Loading...
View Options

scripts/test/deferred_log.php

Loading...
View Options

scripts/test/http.php

Loading...
View Options

scripts/test/interactive_editor.php

Loading...
View Options

scripts/test/lipsum.php

Loading...
View Options

scripts/test/mime.php

Loading...
View Options

scripts/test/paypal.php

Loading...
View Options

scripts/test/progress_bar.php

Loading...
View Options

scripts/test/prompt.php

Loading...
View Options

scripts/test/service_profiler.php

Loading...
View Options

scripts/utils/directory_fixture.php

Loading...
View Options

scripts/utils/lock.php

Loading...
View Options

support/parser/generate-type-parser.php

Loading...
Phabricator · Built by Phacility