Fix HTTP 400 from notification server for JSON subscription objects
ClosedPublic
Actions

Authored by epriestley on Jul 17 2014, 2:19 PM.

Details

Reviewers

joshuaspence

Maniphest Tasks

T5651: "400 Bad Request" errors from Aphlict server

Commits

Restricted Diffusion Commit
rP6bf4ec97d563: Fix HTTP 400 from notification server for JSON subscription objects

Summary

Fixes T5651. Sometime we'll send an object to the notification server for subscribers, which it will choke on. Use array_values() to make sure we're sending an array.

Test Plan

With (object) instead, got a consistent error ("no .filter method on object"). With array_values(), no error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23905.Jul 17 2014, 2:19 PM

epriestley retitled this revision from to Possible fix for HTTP 400 from notification server.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T5651: "400 Bad Request" errors from Aphlict server.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 17 2014, 2:19 PM

Harbormaster completed remote builds in B1741: Diff 23905.Jul 17 2014, 2:20 PM

Also log 400's.
Tested and confirmed it's actually the issue and works. Specifically, I used (object) to reliably reproduce the error:

[Thu Jul 17 2014 14:02:23 GMT-0700 (PDT)] <127.0.0.1> Bad Request! TypeError: Object [object Object] has no method 'filter'

Harbormaster completed remote builds in B1745: Diff 23910.Jul 17 2014, 9:05 PM

Yeah okay... this makes sense.

This revision is now accepted and ready to land.Jul 17 2014, 9:41 PM

(maybe clean up the diff title and summary before landing this)

epriestley retitled this revision from Possible fix for HTTP 400 from notification server to Fix HTTP 400 from notification server for JSON subscription objects.Jul 17 2014, 9:46 PM

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley edited edge metadata.