Page MenuHomePhabricator
Differential D9912

Show a better message for empty repositories and invalid branches
ClosedPublic
Actions

Authored by epriestley on Jul 12 2014, 1:57 PM.
Tags
None
Referenced Files
F18284018: D9912.id23789.diff
Sat, Aug 23, 2:25 AM
F18284002: D9912.id23790.diff
Sat, Aug 23, 2:22 AM
F18260495: D9912.id23790.diff
Fri, Aug 22, 5:29 AM
F18260494: D9912.id23789.diff
Fri, Aug 22, 5:29 AM
F18260492: D9912.id.diff
Fri, Aug 22, 5:29 AM
F18259461: D9912.diff
Fri, Aug 22, 4:21 AM
F18212327: D9912.id23789.diff
Tue, Aug 19, 2:58 AM
F18204644: D9912.diff
Mon, Aug 18, 2:02 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T1493: Empty repositories should show a "this repository is empty" message
Commits
Restricted Diffusion Commit
rPae263ddde5a5: Show a better message for empty repositories and invalid branches
Summary

Ref T1493.

  • When viewing an invalid branch, show a "there is no such branch" message.
  • When viewing an empty repository, show a "this repository is empty" message.
Test Plan
  • Viewed empty, bad branch, and nonempty in Git.
  • Viewed empty, bad branch, and nonempty in Mercurial.
  • Viewed empty and nonempty in Subversion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23789.Jul 12 2014, 1:57 PM
epriestley retitled this revision from to Show a better message for empty repositories and invalid branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T1493: Empty repositories should show a "this repository is empty" message.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 12 2014, 1:57 PM
Harbormaster completed remote builds in B1667: Diff 23789.Jul 12 2014, 1:58 PM
chad accepted this revision.Jul 12 2014, 2:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2014, 2:03 PM
epriestley closed this revision.Jul 12 2014, 2:05 PM
epriestley updated this revision to Diff 23790.

Closed by commit rPae263ddde5a5 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
76 lines
request/
2 lines
2 lines
8 lines
2 lines
repository/
query/
22 lines

Diff 23790

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionGitRequest.php

Loading...
View Options

src/applications/diffusion/request/DiffusionMercurialRequest.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/diffusion/request/DiffusionSvnRequest.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

Loading...
Phabricator · Built by Phacility