Page MenuHomePhabricator

Make typeahead datasources default to PHID type icons
ClosedPublic

Authored by epriestley on Jul 11 2014, 11:32 AM.
Tags
None
Referenced Files
F14838048: D9894.diff
Fri, Jan 31, 1:11 PM
Unknown Object (File)
Thu, Jan 30, 8:44 AM
Unknown Object (File)
Tue, Jan 28, 7:42 AM
Unknown Object (File)
Tue, Jan 28, 7:42 AM
Unknown Object (File)
Tue, Jan 28, 7:42 AM
Unknown Object (File)
Sun, Jan 26, 6:00 PM
Unknown Object (File)
Sat, Jan 25, 5:28 PM
Unknown Object (File)
Tue, Jan 21, 3:06 PM
Subscribers

Details

Summary

Ref T4420. If a datasource does not specify an icon explicitly, check if the PHID type has a default, and use that.

This leaves us with only Projects and some special stuff setting explicit icons, and reduces code duplication.

Test Plan

Used typeahead to find all affected object types.

Diff Detail

Repository
rP Phabricator
Branch
tok8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1642
Build 1643: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make typeahead datasources default to PHID type icons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision is now accepted and ready to land.Jul 17 2014, 10:29 PM
epriestley updated this revision to Diff 23943.

Closed by commit rPb8d604acaf84 (authored by @epriestley).