Page MenuHomePhabricator

Make typeahead datasources default to PHID type icons
ClosedPublic

Authored by epriestley on Jul 11 2014, 11:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 1:38 PM
Unknown Object (File)
Feb 10 2024, 8:17 AM
Unknown Object (File)
Feb 7 2024, 7:52 PM
Unknown Object (File)
Feb 5 2024, 2:17 AM
Unknown Object (File)
Feb 5 2024, 2:17 AM
Unknown Object (File)
Feb 4 2024, 4:38 AM
Unknown Object (File)
Jan 29 2024, 2:56 PM
Unknown Object (File)
Jan 19 2024, 4:00 PM
Subscribers

Details

Summary

Ref T4420. If a datasource does not specify an icon explicitly, check if the PHID type has a default, and use that.

This leaves us with only Projects and some special stuff setting explicit icons, and reduces code duplication.

Test Plan

Used typeahead to find all affected object types.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make typeahead datasources default to PHID type icons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision is now accepted and ready to land.Jul 17 2014, 10:29 PM
epriestley updated this revision to Diff 23943.

Closed by commit rPb8d604acaf84 (authored by @epriestley).