Page MenuHomePhabricator
Differential D9887

Modernize "user or project" typeahead datasources
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 2:55 AM.
Tags
None
Referenced Files
F14116310: D9887.id23938.diff
Thu, Nov 28, 2:51 PM
F14116309: D9887.id23743.diff
Thu, Nov 28, 2:51 PM
F14116262: D9887.diff
Thu, Nov 28, 2:30 PM
Unknown Object (File)
Mon, Nov 25, 5:54 AM
Unknown Object (File)
Sat, Nov 23, 3:50 PM
Unknown Object (File)
Tue, Nov 19, 12:02 AM
Unknown Object (File)
Sun, Nov 10, 7:40 AM
Unknown Object (File)
Mon, Nov 4, 7:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rPca5a2641a6d7: Modernize "user or project" typeahead datasources
Summary

Ref T4420. These are used for some stuff like "reviewer".

Test Plan
  • Edited "reviewers" in differential edit.
  • Edited "reviewers" in differential search.
  • Edited "reviewers" in Differential "add reviewers..." action on detail page.
  • Edited a "reviewers" field in a herald rule.
  • Edited "owner" in owners search.
  • Edited "primary owner", "owners" on owners edit.

Diff Detail

Repository
rP Phabricator
Branch
tok3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1631
Build 1632: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23743.Jul 11 2014, 2:55 AM
epriestley retitled this revision from to Modernize "user or project" typeahead datasources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 2:55 AM
Harbormaster completed remote builds in B1631: Diff 23743.Jul 11 2014, 2:56 AM
btrahan accepted this revision.Jul 17 2014, 10:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:28 PM
epriestley closed this revision.Jul 17 2014, 10:45 PM
epriestley updated this revision to Diff 23938.

Closed by commit rPca5a2641a6d7 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
customfield/
2 lines
query/
2 lines
view/
5 lines
herald/
controller/
4 lines
owners/
controller/
4 lines
2 lines
project/
typeahead/
17 lines
typeahead/
controller/
5 lines
view/
form/
control/
2 lines

Diff 23743

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersEditController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersListController.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectOrUserDatasource.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
Phabricator · Built by Phacility