Page MenuHomePhabricator
Differential D9880

Modernize "owners" datasource
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 10:25 PM.
Tags
None
Referenced Files
F14407888: D9880.id23731.diff
Tue, Dec 24, 3:54 AM
Unknown Object (File)
Wed, Dec 11, 1:11 AM
Unknown Object (File)
Mon, Dec 9, 2:30 PM
Unknown Object (File)
Wed, Dec 4, 12:46 PM
Unknown Object (File)
Tue, Dec 3, 8:36 PM
Unknown Object (File)
Tue, Dec 3, 10:23 AM
Unknown Object (File)
Wed, Nov 27, 2:15 AM
Unknown Object (File)
Wed, Nov 27, 2:09 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rP6eb879210a4f: Modernize "owners" datasource
Summary

Ref T4420. Update owners.

Test Plan
  • Used typeahead from Herald.

Diff Detail

Repository
rP Phabricator
Branch
tok7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1618
Build 1619: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23719.Jul 10 2014, 10:25 PM
epriestley retitled this revision from to Modernize "owners" datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 10:25 PM
Harbormaster completed remote builds in B1618: Diff 23719.Jul 10 2014, 10:26 PM
btrahan accepted this revision.Jul 10 2014, 10:31 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2014, 10:31 PM
btrahan added inline comments.Jul 10 2014, 10:32 PM
src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php
26

getTypeIcon instead? (saw this method in D9878)

epriestley added inline comments.Jul 10 2014, 10:45 PM
src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php
26

I have an even smarter idea on these and I'm going to fix them all up at the end. <_<

epriestley closed this revision.Jul 10 2014, 11:21 PM
epriestley updated this revision to Diff 23731.

Closed by commit rP6eb879210a4f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
herald/
controller/
2 lines
owners/
typeahead/
35 lines
typeahead/
controller/
3 lines

Diff 23719

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
Phabricator · Built by Phacility