Ref T4420. Make this modern.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T4420: Modernize typeahead datasources
- Commits
- Restricted Diffusion Commit
rPa2caea13d65f: Modernize "macro" typeahead datasource
- Used typeahead in remarkup comment area to select macro "derpdog".
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- tok2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1613 Build 1614: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think I'm learning about the nitty gritty of how this icon stuff works over these diffs.
| src/applications/macro/typeahead/PhabricatorMacroDatasource.php | ||
|---|---|---|
| 29 | oh, I guess if you want the color you have to specify it here too? | |
Comment Actions
The icon stuff is dumb right now, my end-of-this-sequence plan is to make Results go look up the PHIDType and use the icon/color on that, if one isn't provided. That will delete 90% of the code and just leave a couple of special cases (mostly projects). For now, I'm just moving the code into modular datasources without touching it too much.