Page MenuHomePhabricator
Differential D9875

Modernize "macro" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 8:43 PM.
Tags
None
Referenced Files
F14060952: D9875.diff
Mon, Nov 18, 4:26 AM
F14046458: D9875.diff
Wed, Nov 13, 9:23 PM
F14036991: D9875.id23713.diff
Sun, Nov 10, 1:18 PM
F14033664: D9875.diff
Sat, Nov 9, 7:04 PM
F14020822: D9875.diff
Wed, Nov 6, 2:58 AM
F14018121: D9875.id23726.diff
Tue, Nov 5, 5:03 AM
F14014410: D9875.id23726.diff
Sun, Nov 3, 3:00 AM
F13996055: D9875.diff
Wed, Oct 23, 5:44 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rPa2caea13d65f: Modernize "macro" typeahead datasource
Summary

Ref T4420. Make this modern.

Test Plan
  • Used typeahead in remarkup comment area to select macro "derpdog".

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23713.Jul 10 2014, 8:43 PM
epriestley retitled this revision from to Modernize "macro" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 8:43 PM
epriestley updated this revision to Diff 23714.Jul 10 2014, 8:43 PM
  • Forgot to save file removing this from common typehead.
Harbormaster completed remote builds in B1612: Diff 23713.Jul 10 2014, 8:44 PM
Harbormaster completed remote builds in B1613: Diff 23714.
btrahan accepted this revision.Jul 10 2014, 10:34 PM
btrahan edited edge metadata.

I think I'm learning about the nitty gritty of how this icon stuff works over these diffs.

src/applications/macro/typeahead/PhabricatorMacroDatasource.php
30

oh, I guess if you want the color you have to specify it here too?

This revision is now accepted and ready to land.Jul 10 2014, 10:34 PM
epriestley added a comment.Jul 10 2014, 10:46 PM

The icon stuff is dumb right now, my end-of-this-sequence plan is to make Results go look up the PHIDType and use the icon/color on that, if one isn't provided. That will delete 90% of the code and just leave a couple of special cases (mostly projects). For now, I'm just moving the code into modular datasources without touching it too much.

epriestley closed this revision.Jul 10 2014, 11:18 PM
epriestley updated this revision to Diff 23726.

Closed by commit rPa2caea13d65f (authored by @epriestley).

Revision Contents
Changeset List

Diff 23726

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroMemeDialogController.php

Loading...
View Options

src/applications/macro/phid/PhabricatorMacroPHIDTypeMacro.php

Loading...
View Options

src/applications/macro/typeahead/PhabricatorMacroDatasource.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeRepository.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
Phabricator · Built by Phacility