Add support for creating revision from existing git commit
Needs RevisionPublic
Actions

Authored by djc on Jul 7 2014, 2:58 PM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Test Plan

basic testing with a sample repository/changeset

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1565
Build 1566: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testSvnStateParsing
	0 ms	testGitStateParsing
	0 ms	testSVNFileEscapes
	0 ms	testHgStateParsing

Event Timeline

djc updated this revision to Diff 23633.Jul 7 2014, 2:58 PM

djc retitled this revision from to Add support for creating revision from existing git commit.

djc updated this object.

djc edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2014, 2:58 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1565: Diff 23633.Jul 7 2014, 2:59 PM

You can already do this with:

$ git show X | arc diff --raw
$ arc diff X^ --head X

If you do this frequently, maybe you could make an alias? I think something like this would work:

$ arc alias diffone -- '!arc diff $0^ --head $0'

...then:

$ arc diffone X

Basically, I'm not sure this is useful enough on its own to justify implementing fully.

Well, I'm not the only one who has been asking for this. And I think you mentioned something about --raw giving the revision not as much context? Or do you just mean Arcanist/Phabricator features that depend on having a working copy, which are impossible to get working anyway in this model?

Harbormaster completed remote builds in B1565: Diff 23633.Jul 8 2014, 12:49 PM