Page MenuHomePhabricator
Differential D9818

Move `PhutilBootloader` into the standard directory structure
ClosedPublic
Actions

Authored by joshuaspence on Jul 4 2014, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 5:10 AM
Unknown Object (File)
Mon, Dec 9, 12:54 AM
Unknown Object (File)
Sat, Dec 7, 3:46 PM
Unknown Object (File)
Fri, Dec 6, 11:59 AM
Unknown Object (File)
Wed, Dec 4, 5:49 AM
Unknown Object (File)
Tue, Dec 3, 3:42 AM
Unknown Object (File)
Fri, Nov 29, 9:14 AM
Unknown Object (File)
Sun, Nov 24, 4:32 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU8571a9256f2d: Move `PhutilBootloader` into the standard directory structure
Summary

Move PhutilBootloader and other related classes/functions into the standard directory structure. Whilst there is no compelling reason that we have to do this, it does make the code in libphutil/src/__phutil_library_init__.php a bit cleaner.

Test Plan

Verfied that arc liberate and arc unit still worked.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23559.Jul 4 2014, 5:34 AM
joshuaspence retitled this revision from to Move `PhutilBootloader` into the standard directory structure.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 4 2014, 5:34 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1515: Diff 23559.Jul 4 2014, 5:35 AM
epriestley accepted this revision.Jul 4 2014, 2:51 PM
epriestley edited edge metadata.

Yeah, this is way cleaner. I think long ago I believe there were technical reasons why this didn't work, but I think we fixed that stuff a while ago.

This revision is now accepted and ready to land.Jul 4 2014, 2:51 PM
joshuaspence closed this revision.Jul 5 2014, 6:31 AM
joshuaspence updated this revision to Diff 23569.

Closed by commit rPHU8571a9256f2d (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
359 lines
8 lines
moduleutils/
PhutilBootloader.php
__phutil_library_init__.php
154 lines
moduleutils/
6 lines
85 lines
22 lines
1 line

Diff 23569

View Options

src/__phutil_library_init__.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/moduleutils/PhutilBootloader.php

Loading...
View Options

src/moduleutils/PhutilBootloaderException.php

Loading...
View Options

src/moduleutils/PhutilLibraryConflictException.php

Loading...
View Options

src/moduleutils/core.php

Loading...
View Options

src/moduleutils/moduleutils.php

Loading...
Phabricator · Built by Phacility