Differential D9816

Allow users to specify names of build steps
ClosedPublic
Actions

Authored by hach-que on Jul 4 2014, 3:34 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rPa3d50118e117: Allow users to specify names of build steps

Summary

Ref T1049. This provides a user-configurable name field on build steps, which allows users to uniquely identify their steps. The intention is that this field will be used in D9806 to better identify the dependencies (rather than showing an unhelpful PHID).

Test Plan

Set the name of some build steps, saw it appear in the correct places.

Diff Detail

Repository

rP Phabricator

Branch

step-name

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1518
Build 1518: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 23553.Jul 4 2014, 3:34 AM

hach-que retitled this revision from to Allow users to specify names of build steps.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T1049: Implement Harbormaster.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 4 2014, 3:34 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1511: Diff 23553.Jul 4 2014, 3:36 AM

epriestley accepted this revision.Jul 4 2014, 2:53 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php
105	You can safely just: if (strlen($this->name)) { return $this->name; } ...to simplify this a little.
src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
55	(As above.)