Page MenuHomePhabricator

Fatal during setup for "mbstring.func_overload"
ClosedPublic

Authored by epriestley on Jul 3 2014, 6:32 PM.
Tags
None
Referenced Files
F14415830: D9811.diff
Tue, Dec 24, 7:21 PM
Unknown Object (File)
Sun, Dec 15, 6:03 AM
Unknown Object (File)
Fri, Dec 13, 4:19 AM
Unknown Object (File)
Thu, Dec 12, 11:22 PM
Unknown Object (File)
Tue, Nov 26, 11:51 PM
Unknown Object (File)
Tue, Nov 26, 10:18 AM
Unknown Object (File)
Tue, Nov 26, 10:18 AM
Unknown Object (File)
Tue, Nov 26, 9:48 AM
Subscribers

Details

Summary

Fixes T5545. We assume strlen() returns the number of bytes in a string, which is the normal behavior (and the documented behavior).

There's a config option, mbstring.func_overload, which silently calls mb_strlen() instead. This may return some other result, might fail, etc., and there's no way to get the byte length of a string if this option is set.

If this option is set, fatal immediately. Nothing good can ever come of it.

Test Plan

Screen_Shot_2014-07-03_at_11.29.25_AM.png (861×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fatal during setup for "mbstring.func_overload".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 3 2014, 8:36 PM
epriestley updated this revision to Diff 23560.

Closed by commit rP04d5402e2fdd (authored by @epriestley).