Page MenuHomePhabricator

Fatal during setup for "mbstring.func_overload"
ClosedPublic

Authored by epriestley on Jul 3 2014, 6:32 PM.
Tags
None
Referenced Files
F18755683: D9811.id23543.diff
Sun, Oct 5, 6:55 AM
F18735001: D9811.id.diff
Tue, Sep 30, 11:07 PM
F18704025: D9811.diff
Sun, Sep 28, 6:00 AM
F18680850: D9811.id23560.diff
Fri, Sep 26, 3:14 AM
F18557981: D9811.id.diff
Sep 8 2025, 8:13 PM
F18515039: D9811.diff
Sep 5 2025, 10:59 AM
F18111683: D9811.diff
Aug 12 2025, 11:16 AM
F18092743: D9811.diff
Aug 7 2025, 12:52 PM
Subscribers

Details

Summary

Fixes T5545. We assume strlen() returns the number of bytes in a string, which is the normal behavior (and the documented behavior).

There's a config option, mbstring.func_overload, which silently calls mb_strlen() instead. This may return some other result, might fail, etc., and there's no way to get the byte length of a string if this option is set.

If this option is set, fatal immediately. Nothing good can ever come of it.

Test Plan

Screen_Shot_2014-07-03_at_11.29.25_AM.png (861×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fatal during setup for "mbstring.func_overload".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 3 2014, 8:36 PM
epriestley updated this revision to Diff 23560.

Closed by commit rP04d5402e2fdd (authored by @epriestley).