Page MenuHomePhabricator

Fatal during setup for "mbstring.func_overload"
ClosedPublic

Authored by epriestley on Jul 3 2014, 6:32 PM.
Tags
None
Referenced Files
F19060570: D9811.id23560.diff
Sat, Nov 29, 9:42 AM
F19051757: D9811.id23543.diff
Fri, Nov 28, 1:52 AM
F19001162: D9811.id.diff
Fri, Nov 21, 2:02 AM
F18999247: D9811.diff
Thu, Nov 20, 8:39 PM
F18791923: D9811.id23543.diff
Oct 16 2025, 6:38 PM
F18791786: D9811.id23560.diff
Oct 16 2025, 5:59 PM
F18791584: D9811.id.diff
Oct 16 2025, 3:28 PM
F18755683: D9811.id23543.diff
Oct 5 2025, 6:55 AM
Subscribers

Details

Summary

Fixes T5545. We assume strlen() returns the number of bytes in a string, which is the normal behavior (and the documented behavior).

There's a config option, mbstring.func_overload, which silently calls mb_strlen() instead. This may return some other result, might fail, etc., and there's no way to get the byte length of a string if this option is set.

If this option is set, fatal immediately. Nothing good can ever come of it.

Test Plan

Screen_Shot_2014-07-03_at_11.29.25_AM.png (861×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fatal during setup for "mbstring.func_overload".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 3 2014, 8:36 PM
epriestley updated this revision to Diff 23560.

Closed by commit rP04d5402e2fdd (authored by @epriestley).