Page MenuHomePhabricator

Fatal during setup for "mbstring.func_overload"
ClosedPublic

Authored by epriestley on Jul 3 2014, 6:32 PM.
Tags
None
Referenced Files
F15431119: D9811.diff
Mar 24 2025, 10:38 AM
F15429396: D9811.id.diff
Mar 24 2025, 1:55 AM
F15427837: D9811.id23543.diff
Mar 23 2025, 4:15 PM
F15427106: D9811.id23560.diff
Mar 23 2025, 12:53 PM
F15423047: D9811.diff
Mar 22 2025, 12:24 PM
F15414014: D9811.diff
Mar 19 2025, 10:30 PM
F15384365: D9811.id23560.diff
Mar 14 2025, 7:38 PM
F15374268: D9811.id23543.diff
Mar 12 2025, 6:05 PM
Subscribers

Details

Summary

Fixes T5545. We assume strlen() returns the number of bytes in a string, which is the normal behavior (and the documented behavior).

There's a config option, mbstring.func_overload, which silently calls mb_strlen() instead. This may return some other result, might fail, etc., and there's no way to get the byte length of a string if this option is set.

If this option is set, fatal immediately. Nothing good can ever come of it.

Test Plan

Screen_Shot_2014-07-03_at_11.29.25_AM.png (861×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fatal during setup for "mbstring.func_overload".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 3 2014, 8:36 PM
epriestley updated this revision to Diff 23560.

Closed by commit rP04d5402e2fdd (authored by @epriestley).