Page MenuHomePhabricator

List the repositories linked to the current showing project.
Needs RevisionPublic

Authored by Mayeu on Jul 3 2014, 1:42 PM.

Details

Summary

When repositories are linked to a project, those repositories do not
show up on the project page. This patch allow this.

Test Plan

Ensured linked repositories shows in my test instance. I did not find any test
folder to add a unit test for this.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Error/home/mayeu/code/libphutil/src/auth/PhutilAuthAdapterOAuthJIRA.php:112PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/auth/PhutilAuthAdapterOAuthJIRA.php:118PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/auth/PhutilAuthAdapterOAuthJIRA.php:123PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/filesystem/Filesystem.php:403PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:234PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:239PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:245PHL1Unknown Symbol
Error/home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:250PHL1Unknown Symbol
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:54PHL1Unknown Symbol
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:70PHL1Unknown Symbol
Errorsrc/applications/phragment/storage/PhragmentFragment.php:143PHL1Unknown Symbol
Errorsrc/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php:75PHL1Unknown Symbol
Errorsrc/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php:75PHL1Unknown Symbol
Unit
No Test Coverage
Build Status
Buildable 1500
Build 1500: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Mayeu retitled this revision from to List the repositories linked to the current showing project..
Mayeu updated this object.
Mayeu edited the test plan for this revision. (Show Details)
Mayeu added a reviewer: epriestley.
epriestley edited edge metadata.

From a technical point of view, this field won't hide if Diffusion is uninstalled or not visible to the viewer. The field should be added by an event listener instead.

From a product point of view, we don't want to go in this direction in the upstream. See discussion in T5034.

This revision now requires changes to proceed.Jul 4 2014, 2:58 PM

Thank you fro your feedback on this!

In D9808#6, @epriestley wrote:

From a technical point of view, this field won't hide if Diffusion is uninstalled or not visible to the viewer. The field should be added by an event listener instead.

Can you point me on own I can check if an application is installed or not? I took my inspiration from the code of Diffusion which does not seems to check if Project is installed or not.