When repositories are linked to a project, those repositories do not
show up on the project page. This patch allow this.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5034: Show repositories when viewing a project
Ensured linked repositories shows in my test instance. I did not find any test
folder to add a unit test for this.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Errors Severity Location Code Message Error /home/mayeu/code/libphutil/src/auth/PhutilAuthAdapterOAuthJIRA.php:112 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/auth/PhutilAuthAdapterOAuthJIRA.php:118 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/auth/PhutilAuthAdapterOAuthJIRA.php:123 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/filesystem/Filesystem.php:403 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:234 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:239 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:245 PHL1 Unknown Symbol Error /home/mayeu/code/libphutil/src/future/oauth/PhutilOAuth1Future.php:250 PHL1 Unknown Symbol Error src/applications/phragment/controller/PhragmentZIPController.php:54 PHL1 Unknown Symbol Error src/applications/phragment/controller/PhragmentZIPController.php:70 PHL1 Unknown Symbol Error src/applications/phragment/storage/PhragmentFragment.php:143 PHL1 Unknown Symbol Error src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php:75 PHL1 Unknown Symbol Error src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php:75 PHL1 Unknown Symbol - Unit
No Test Coverage - Build Status
Buildable 1500 Build 1500: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
From a technical point of view, this field won't hide if Diffusion is uninstalled or not visible to the viewer. The field should be added by an event listener instead.
From a product point of view, we don't want to go in this direction in the upstream. See discussion in T5034.
Comment Actions
Thank you fro your feedback on this!
Can you point me on own I can check if an application is installed or not? I took my inspiration from the code of Diffusion which does not seems to check if Project is installed or not.