Allow Legalpad document managers to add signature exemptions
ClosedPublic
Actions

Authored by epriestley on Jul 2 2014, 3:46 AM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5532: Support corporate CLAs and signature exemptions

Commits

Restricted Diffusion Commit
rPb6ea2735d72c: Allow Legalpad document managers to add signature exemptions

Summary

Ref T5532. Allow document managers to add exemptions, which act like signatures but are tracked a little differently.

The primary use case for us is users who sign a corporate CLA and need a user-level exemption if they don't want to sign an individual CLA.

Test Plan

See screenshots.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23508.Jul 2 2014, 3:46 AM

epriestley retitled this revision from to Allow Legalpad document managers to add signature exemptions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5532: Support corporate CLAs and signature exemptions.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 2 2014, 3:46 AM

Harbormaster completed remote builds in B1482: Diff 23508.Jul 2 2014, 3:47 AM

New "Add exemption" button:

Screen_Shot_2014-07-01_at_8.37.46_PM.png (828×1 px, 112 KB)

Add exemption dialog:

Screen_Shot_2014-07-01_at_8.38.41_PM.png (828×1 px, 124 KB)

An exemption:

Screen_Shot_2014-07-01_at_8.38.53_PM.png (828×1 px, 120 KB)

Exemption detail:

Screen_Shot_2014-07-01_at_8.38.55_PM.png (828×1 px, 111 KB)

Altered signature message:

Screen_Shot_2014-07-01_at_8.42.06_PM.png (828×1 px, 94 KB)

chad accepted this revision.Jul 2 2014, 5:45 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2014, 5:45 AM

Closed by commit rPb6ea2735d72c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140701.legalexemption.1.sql

2 lines

20140701.legalexemption.2.sql

2 lines

src/

__phutil_library_map__.php

4 lines

applications/

legalpad/

application/

PhabricatorApplicationLegalpad.php

5 lines

controller/

LegalpadDocumentSignController.php

24 lines

LegalpadDocumentSignatureAddController.php

127 lines

LegalpadDocumentSignatureViewController.php

71 lines

query/

LegalpadDocumentSignatureSearchEngine.php

35 lines

storage/

LegalpadDocumentSignature.php

2 lines

docs/

user/

userguide/

legalpad.diviner

21 lines

Diff 23513

View Options

resources/sql/autopatches/20140701.legalexemption.1.sql

View Options

resources/sql/autopatches/20140701.legalexemption.2.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/legalpad/application/PhabricatorApplicationLegalpad.php

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

View Options

src/applications/legalpad/controller/LegalpadDocumentSignatureAddController.php

View Options

src/applications/legalpad/controller/LegalpadDocumentSignatureViewController.php

View Options

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

View Options

src/applications/legalpad/storage/LegalpadDocumentSignature.php

View Options

src/docs/user/userguide/legalpad.diviner

Allow Legalpad document managers to add signature exemptionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23513

resources/sql/autopatches/20140701.legalexemption.1.sql

resources/sql/autopatches/20140701.legalexemption.2.sql

src/__phutil_library_map__.php

src/applications/legalpad/application/PhabricatorApplicationLegalpad.php

src/applications/legalpad/controller/LegalpadDocumentSignController.php

src/applications/legalpad/controller/LegalpadDocumentSignatureAddController.php

src/applications/legalpad/controller/LegalpadDocumentSignatureViewController.php

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

src/applications/legalpad/storage/LegalpadDocumentSignature.php

src/docs/user/userguide/legalpad.diviner

Allow Legalpad document managers to add signature exemptions
ClosedPublic
Actions

Revision Contents
Changeset List