Page MenuHomePhabricator

Don't atomize closures
ClosedPublic

Authored by Firehed on Jun 30 2014, 6:12 PM.
Tags
None
Referenced Files
F14407431: D9786.diff
Tue, Dec 24, 2:55 AM
Unknown Object (File)
Mon, Dec 9, 10:45 PM
Unknown Object (File)
Mon, Dec 9, 12:00 PM
Unknown Object (File)
Wed, Dec 4, 7:16 PM
Unknown Object (File)
Thu, Nov 28, 5:12 PM
Unknown Object (File)
Thu, Nov 28, 5:12 PM
Unknown Object (File)
Nov 20 2024, 3:43 AM
Unknown Object (File)
Nov 16 2024, 9:47 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPede6947dd1ef: Don't atomize closures
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

In a PHP5.3+ codebase with closures, Diviner would pick up anonymous functions and add them into the generated documentation. This causes them to be skipped.

Test Plan

Ran bin/diviner generate --clean before and after change, no longer got a bunch of unnamed functions dumped into the documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Firehed retitled this revision from to Don't atomize closures.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
Firehed added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2014, 1:16 PM
epriestley updated this revision to Diff 23500.

Closed by commit rPede6947dd1ef (authored by @Firehed, committed by @epriestley).