Don't atomize closures
ClosedPublic
Actions

Authored by Firehed on Jun 30 2014, 6:12 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPede6947dd1ef: Don't atomize closures

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

In a PHP5.3+ codebase with closures, Diviner would pick up anonymous functions and add them into the generated documentation. This causes them to be skipped.

Test Plan

Ran bin/diviner generate --clean before and after change, no longer got a bunch of unnamed functions dumped into the documentation.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Firehed updated this revision to Diff 23490.Jun 30 2014, 6:12 PM

Firehed retitled this revision from to Don't atomize closures.

Firehed updated this object.

Firehed edited the test plan for this revision. (Show Details)

Firehed added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 30 2014, 6:12 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1470: Diff 23490.Jun 30 2014, 6:14 PM

epriestley accepted this revision.Jul 1 2014, 1:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 1 2014, 1:16 PM

Closed by commit rPede6947dd1ef (authored by @Firehed, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

atomizer/

DivinerPHPAtomizer.php

5 lines

Diff 23500

View Options

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

Don't atomize closuresClosedPublicActions