Don't colorize Project tokenizer icons for now
ClosedPublic
Actions

Authored by epriestley on Jun 26 2014, 5:11 AM.

Tags

None

Referenced Files

	F13812857: D9740.diff
	Wed, Sep 18, 6:24 PM

	F13811731: D9740.id.diff
	Wed, Sep 18, 6:29 AM

	Unknown Object (File)
	Sat, Sep 14, 9:33 PM

	Unknown Object (File)
	Thu, Sep 12, 3:21 AM

	Unknown Object (File)
	Mon, Aug 26, 1:31 AM

	Unknown Object (File)
	Sun, Aug 25, 11:58 PM

	Unknown Object (File)
	Thu, Aug 22, 7:17 PM

	Unknown Object (File)
	Wed, Aug 21, 8:38 PM

View All Files

Subscribers

epriestley

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP3d1e86580442: Don't colorize Project tokenizer icons for now

Summary

We can take a shot at doing this properly tomorrow and see if we like it, but it's a little weird/inconsistent/unexpected right now.

Test Plan

Used typeahead for projects.

Diff Detail

Repository

rP Phabricator

Branch

notypecolor

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1410
Build 1410: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23391.Jun 26 2014, 5:11 AM

epriestley retitled this revision from to Don't colorize Project tokenizer icons for now.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 26 2014, 5:11 AM

chad accepted this revision.Jun 26 2014, 5:12 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 26 2014, 5:12 AM

Harbormaster completed remote builds in B1410: Diff 23391.Jun 26 2014, 5:12 AM

Closed by commit rP3d1e86580442 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

typeahead/

controller/

PhabricatorTypeaheadCommonDatasourceController.php

2 lines

Diff 23391

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Don't colorize Project tokenizer icons for nowClosedPublicActions