Differential D9714

Disable Maniphest task list grips in panel rendering contexts
ClosedPublic
Actions

Authored by epriestley on Jun 24 2014, 10:57 PM.

Tags

None

Referenced Files

	F15465229: D9714.id23326.diff
	Wed, Apr 2, 4:22 PM

	F15455822: D9714.id23326.diff
	Sun, Mar 30, 5:02 AM

	F15455821: D9714.id23325.diff
	Sun, Mar 30, 5:02 AM

	F15445012: D9714.id23326.diff
	Thu, Mar 27, 12:18 PM

	F15413610: D9714.id23325.diff
	Wed, Mar 19, 7:57 PM

	F15386040: D9714.id23325.diff
	Fri, Mar 14, 11:55 PM

	F15384533: D9714.id23326.diff
	Fri, Mar 14, 8:11 PM

	F15284261: D9714.diff
	Mar 4 2025, 9:29 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5467: Turn grippable off in Dashboards?

Commits

Restricted Diffusion Commit
rPe6190ffc6770: Disable Maniphest task list grips in panel rendering contexts

Summary

Fixes T5467.

Let search engines figure out if they're rendering for a panel or not.
If Maniphest is rendering a panel, turn off the grips and batch selection.

Test Plan

Viewed task panels (no grips).
Viewed non-panel query results (grips).

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23325.Jun 24 2014, 10:57 PM

epriestley retitled this revision from to Disable Maniphest task list grips in panel rendering contexts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5467: Turn grippable off in Dashboards?.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 24 2014, 10:57 PM

chad accepted this revision.Jun 24 2014, 10:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 24 2014, 10:57 PM

Harbormaster completed remote builds in B1370: Diff 23325.Jun 24 2014, 10:58 PM

Closed by commit rPe6190ffc6770 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

paneltype/

PhabricatorDashboardPanelTypeQuery.php

1 line

maniphest/

query/

ManiphestTaskSearchEngine.php

23 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

13 lines

Diff 23326

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php

Loading...

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...