Page MenuHomePhabricator
Differential D9714

Disable Maniphest task list grips in panel rendering contexts
ClosedPublic
Actions

Authored by epriestley on Jun 24 2014, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 7:00 PM
Unknown Object (File)
Mon, Jan 27, 1:57 AM
Unknown Object (File)
Sat, Jan 25, 6:48 AM
Unknown Object (File)
Tue, Jan 21, 9:11 AM
Unknown Object (File)
Sun, Jan 19, 5:37 PM
Unknown Object (File)
Sat, Jan 18, 8:51 AM
Unknown Object (File)
Tue, Dec 31, 2:26 PM
Unknown Object (File)
Dec 25 2024, 11:41 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5467: Turn grippable off in Dashboards?
Commits
Restricted Diffusion Commit
rPe6190ffc6770: Disable Maniphest task list grips in panel rendering contexts
Summary

Fixes T5467.

  • Let search engines figure out if they're rendering for a panel or not.
  • If Maniphest is rendering a panel, turn off the grips and batch selection.
Test Plan
  • Viewed task panels (no grips).
  • Viewed non-panel query results (grips).

Diff Detail

Repository
rP Phabricator
Branch
panelcontext
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1370
Build 1370: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23325.Jun 24 2014, 10:57 PM
epriestley retitled this revision from to Disable Maniphest task list grips in panel rendering contexts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5467: Turn grippable off in Dashboards?.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 24 2014, 10:57 PM
chad accepted this revision.Jun 24 2014, 10:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2014, 10:57 PM
Harbormaster completed remote builds in B1370: Diff 23325.Jun 24 2014, 10:58 PM
epriestley closed this revision.Jun 24 2014, 10:59 PM
epriestley updated this revision to Diff 23326.

Closed by commit rPe6190ffc6770 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
paneltype/
1 line
maniphest/
query/
23 lines
search/
engine/
13 lines

Diff 23325

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility