Page MenuHomePhabricator
Differential D9708

Adding project tags to slowvote polls
ClosedPublic
Actions

Authored by lpriestley on Jun 24 2014, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:52 AM
Unknown Object (File)
Tue, Dec 17, 5:56 AM
Unknown Object (File)
Thu, Dec 12, 7:39 PM
Unknown Object (File)
Mon, Dec 9, 10:15 PM
Unknown Object (File)
Tue, Dec 3, 1:36 PM
Unknown Object (File)
Tue, Dec 3, 11:42 AM
Unknown Object (File)
Tue, Nov 26, 9:05 AM
Unknown Object (File)
Tue, Nov 26, 9:05 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP15a1f0830160: Adding project tags to slowvote polls
Summary

T2628, project tags in slowvote polls

Test Plan

Open poll, edit, add project tags, save. Poll should show tagged projects and a relevant transaction. (transaction doesn't currently show up)

Diff Detail

Repository
rP Phabricator
Branch
projectsforslowvote
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1362
Build 1362: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 23313.Jun 24 2014, 5:01 PM
lpriestley retitled this revision from to Adding project tags to slowvote polls.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 24 2014, 5:01 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1361: Diff 23313.Jun 24 2014, 5:02 PM
epriestley requested changes to this revision.Jun 24 2014, 5:05 PM
epriestley edited edge metadata.

I think I found it. We should probably detect this automatically, although it's a little bit tricky to do so.

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
112

A PholioTransaction is being inserted instead of a PhabricatorSlowvoteTransaction.

This revision now requires changes to proceed.Jun 24 2014, 5:05 PM
lpriestley updated this revision to Diff 23314.Jun 24 2014, 5:08 PM
lpriestley edited edge metadata.

Fixing copy/pasta issue

Harbormaster completed remote builds in B1362: Diff 23314.Jun 24 2014, 5:09 PM
epriestley accepted this revision.Jun 24 2014, 5:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2014, 5:12 PM
epriestley closed this revision.Jun 24 2014, 5:13 PM
epriestley updated this revision to Diff 23315.

Closed by commit rP15a1f0830160 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
slowvote/
controller/
30 lines
editor/
2 lines
storage/
3 lines

Diff 23314

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
Phabricator · Built by Phacility