Paths

Table of Contentst

Pass the file contents instead of the file path to `phutil_json_decode`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 24 2014, 1:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 12:55 AM

	Unknown Object (File)
	Tue, Dec 17, 5:01 AM

	Unknown Object (File)
	Sun, Dec 15, 6:02 AM

	Unknown Object (File)
	Sun, Dec 8, 8:06 AM

	Unknown Object (File)
	Sun, Dec 8, 12:25 AM

	Unknown Object (File)
	Sat, Dec 7, 11:59 AM

	Unknown Object (File)
	Fri, Nov 29, 4:25 AM

	Unknown Object (File)
	Mon, Nov 25, 4:59 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC108a4dc9e6ca: Pass the file contents instead of the file path to `phutil_json_decode`.

Summary

See D9681#22.

Test Plan

Created an empty .git/arc/config file... no exception was thrown.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23297.Jun 24 2014, 1:41 AM

joshuaspence retitled this revision from to Pass the file contents instead of the file path to `phutil_json_decode`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 24 2014, 1:41 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1353: Diff 23297.Jun 24 2014, 1:42 AM

epriestley accepted this revision.Jun 24 2014, 2:01 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 24 2014, 2:01 AM

Closed by commit rARC108a4dc9e6ca (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

workingcopyidentity/

ArcanistWorkingCopyIdentity.php

3 lines

Diff 23298

View Options

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

Pass the file contents instead of the file path to `phutil_json_decode`.ClosedPublicActions