Page MenuHomePhabricator

Don't validate Conduit hosts
ClosedPublic

Authored by epriestley on Jun 24 2014, 12:12 AM.
Tags
None
Referenced Files
F13997575: D9703.id23296.diff
Thu, Oct 24, 5:12 AM
F13988041: D9703.diff
Mon, Oct 21, 12:47 PM
F13979159: D9703.id23295.diff
Oct 19 2024, 2:58 AM
F13972187: D9703.id.diff
Oct 17 2024, 5:34 PM
Unknown Object (File)
Oct 12 2024, 3:18 PM
Unknown Object (File)
Sep 9 2024, 5:18 PM
Unknown Object (File)
Aug 31 2024, 4:45 PM
Unknown Object (File)
Aug 26 2024, 5:12 AM
Subscribers

Details

Reviewers
joshuaspence
Commits
Restricted Diffusion Commit
rP85e9f8374a35: Don't validate Conduit hosts
Summary

(See rPd1d3bf4e / rPf371c7b3.) Just get rid of this logic, I don't think there's any value to it.

IIRC, this was added a long time ago to deal with some issues that users had configuring things, but I think modern Phabricator covers all this stuff and I haven't seen any confusion from users for a year or more.

(Generally, I want to generally make Conduit easier to use, and this makes it more difficult.)

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't validate Conduit hosts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
This revision is now accepted and ready to land.Jun 24 2014, 12:32 AM
epriestley updated this revision to Diff 23296.

Closed by commit rP85e9f8374a35 (authored by @epriestley).