Make JX.Aphlict a real singleton with a more sensible initialization order
ClosedPublic
Actions

Authored by epriestley on Jun 23 2014, 9:08 PM.

Details

Reviewers

joshuaspence

Maniphest Tasks

T5373: Debugging the `AphlictClient` and `AphlictMaster` is difficult

Commits

Restricted Diffusion Commit
rPdd91732df338: Make JX.Aphlict a real singleton with a more sensible initialization order

Summary

Ref T5373. The control flow between aphlict-listener and JX.Aphlict is pretty weird right now, where the listener (which is the highest-level component) has intimate knowledge of how to put the SWF on the page.

Instead:

Make JX.Aphlict a real singleton.
Instantiate it sooner.
Have it handle the flash setup handshake.

Test Plan

Loaded page in debug mode, saw normal flow take place.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23277.Jun 23 2014, 9:08 PM

epriestley retitled this revision from to Make JX.Aphlict a real singleton with a more sensible initialization order.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

epriestley added a task: T5373: Debugging the `AphlictClient` and `AphlictMaster` is difficult.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2014, 9:08 PM

Harbormaster completed remote builds in B1346: Diff 23277.Jun 23 2014, 9:09 PM

epriestley added inline comments.Jun 23 2014, 9:09 PM

support/aphlict/client/src/AphlictClient.as
61	This event was purely informational and served no real purpose. We can get everything we need with status events instead.
webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js
105	This event is gone; now we just use "status = ready".