Page MenuHomePhabricator
Differential D9698

Install an uncaught exception handler in Aphlict
ClosedPublic
Actions

Authored by epriestley on Jun 23 2014, 8:47 PM.
Tags
None
Referenced Files
F17115941: D9698.diff
Thu, Jun 19, 1:34 PM
Unknown Object (File)
Wed, Jun 18, 5:06 AM
Unknown Object (File)
Mon, Jun 9, 2:29 AM
Unknown Object (File)
May 19 2025, 7:37 PM
Unknown Object (File)
May 10 2025, 1:46 AM
Unknown Object (File)
Apr 25 2025, 9:47 PM
Unknown Object (File)
Apr 25 2025, 4:24 PM
Unknown Object (File)
Apr 23 2025, 1:37 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
Maniphest Tasks
T5373: Debugging the `AphlictClient` and `AphlictMaster` is difficult
Commits
Restricted Diffusion Commit
rP80f26e96ea40: Install an uncaught exception handler in Aphlict
Summary

Ref T5373. This seems to work pretty much correctly.

Also stop popping bubbles and just use the log, since users find the bubbles confusing/not useful and they're not great for developers either.

Future diffs will expose more user-facing stuff.

Test Plan

Added throw to AphlictClient.as, got a log in the parent window.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23275.Jun 23 2014, 8:47 PM
epriestley retitled this revision from to Install an uncaught exception handler in Aphlict.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
epriestley added a task: T5373: Debugging the `AphlictClient` and `AphlictMaster` is difficult.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2014, 8:47 PM
Harbormaster completed remote builds in B1344: Diff 23275.Jun 23 2014, 8:48 PM
joshuaspence edited edge metadata.Jun 23 2014, 8:51 PM

Is the 2048 error meant to show up in the console? I'm not seeing it.

epriestley added a comment.Jun 23 2014, 9:00 PM

Hmm, shows up for me:

Screen_Shot_2014-06-23_at_2.00.27_PM.png (160×475 px, 17 KB)

Let me try something...

epriestley updated this revision to Diff 23276.Jun 23 2014, 9:02 PM
epriestley edited edge metadata.
  • Accept Object instead of Error in this.error(...)
epriestley added a comment.Jun 23 2014, 9:02 PM

This one any better?

epriestley added a comment.Jun 23 2014, 9:03 PM

Screen_Shot_2014-06-23_at_2.02.50_PM.png (1×1 px, 237 KB)

Harbormaster completed remote builds in B1345: Diff 23276.Jun 23 2014, 9:03 PM
joshuaspence added a comment.Jun 23 2014, 9:05 PM

Nope, still completely blank for me.

epriestley added a comment.Jun 23 2014, 9:10 PM

(You have notification.debug enabled, I assume?)

joshuaspence added a comment.Jun 23 2014, 9:11 PM

Ahhhh nevermind... I thought I had notification.debug enabled, but it turns out my config file was invalid JSON:


  "notification.debug": true
}
joshuaspence added inline comments.Jun 23 2014, 9:13 PM
support/aphlict/client/src/Aphlict.as
37

Is this necessary?

epriestley added inline comments.Jun 23 2014, 9:15 PM
support/aphlict/client/src/Aphlict.as
37

It seems that Flash lets us get away with it, but it's more correct to use Object since we sometimes pass strings, not errors.

joshuaspence accepted this revision.Jun 23 2014, 9:16 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 9:16 PM
epriestley closed this revision.Jun 23 2014, 10:18 PM
epriestley updated this revision to Diff 23285.

Closed by commit rP80f26e96ea40 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
src/
2 lines
10 lines
webroot/
rsrc/
js/
application/
aphlict/
20 lines
swf/

Diff 23285

View Options

support/aphlict/client/src/Aphlict.as

Loading...
View Options

support/aphlict/client/src/AphlictClient.as

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility