Page MenuHomePhabricator

Install an uncaught exception handler in Aphlict
ClosedPublic

Authored by epriestley on Jun 23 2014, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 10, 4:21 AM
Unknown Object (File)
Wed, Aug 21, 6:02 PM
Unknown Object (File)
Aug 19 2024, 10:36 PM
Unknown Object (File)
Aug 19 2024, 10:25 PM
Unknown Object (File)
Aug 19 2024, 8:13 PM
Unknown Object (File)
Aug 15 2024, 1:18 PM
Unknown Object (File)
Aug 14 2024, 7:40 AM
Unknown Object (File)
Aug 9 2024, 7:56 AM
Subscribers

Details

Summary

Ref T5373. This seems to work pretty much correctly.

Also stop popping bubbles and just use the log, since users find the bubbles confusing/not useful and they're not great for developers either.

Future diffs will expose more user-facing stuff.

Test Plan

Added throw to AphlictClient.as, got a log in the parent window.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Install an uncaught exception handler in Aphlict.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.

Is the 2048 error meant to show up in the console? I'm not seeing it.

Hmm, shows up for me:

Screen_Shot_2014-06-23_at_2.00.27_PM.png (160×475 px, 17 KB)

Let me try something...

epriestley edited edge metadata.
  • Accept Object instead of Error in this.error(...)

Nope, still completely blank for me.

(You have notification.debug enabled, I assume?)

Ahhhh nevermind... I thought I had notification.debug enabled, but it turns out my config file was invalid JSON:


  "notification.debug": true
}
support/aphlict/client/src/Aphlict.as
37

Is this necessary?

support/aphlict/client/src/Aphlict.as
37

It seems that Flash lets us get away with it, but it's more correct to use Object since we sometimes pass strings, not errors.

This revision is now accepted and ready to land.Jun 23 2014, 9:16 PM
epriestley updated this revision to Diff 23285.

Closed by commit rP80f26e96ea40 (authored by @epriestley).