Recover from `null` authors in commit parsing
ClosedPublic
Actions

Authored by epriestley on Jun 23 2014, 2:22 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5445: Importing svn repository error

Commits

Restricted Diffusion Commit
rP40fa4799a32d: Recover from `null` authors in commit parsing

Summary

Fixes T5445. Some import tools and other unusual situations can leave repositories with commits that don't have authors. This fails on insert.

Instead, explicitly cast the value to a string.

Test Plan

I didn't build a local repro, but see task/GitHub.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23233.Jun 23 2014, 2:22 PM

epriestley retitled this revision from to Recover from `null` authors in commit parsing.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5445: Importing svn repository error.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2014, 2:22 PM

chad accepted this revision.Jun 23 2014, 2:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2014, 2:23 PM

Harbormaster completed remote builds in B1322: Diff 23233.Jun 23 2014, 2:23 PM

Closed by commit rP40fa4799a32d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

2 lines

Diff 23234

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Recover from `null` authors in commit parsingClosedPublicActions