Differential D9682

Fix CPP Lint severity
ClosedPublic
Actions

Authored by prmshepherd on Jun 23 2014, 10:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 5, 1:21 AM

	Unknown Object (File)
	Mon, Aug 26, 4:12 AM

	Unknown Object (File)
	Sat, Aug 24, 2:38 PM

	Unknown Object (File)
	Thu, Aug 22, 3:46 AM

	Unknown Object (File)
	Wed, Aug 21, 11:39 PM

	Unknown Object (File)
	Aug 20 2024, 11:22 PM

	Unknown Object (File)
	Aug 17 2024, 9:09 PM

	Unknown Object (File)
	Aug 16 2024, 4:16 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCddfdfce3f57e: Fix CPP Lint severity

Summary

Currently all CPPLint issues are hard-coded to warning level, which prevents customising the severity in .arclint. Change to pick up the configured severity. Note that getLintMessageSeverity will call getDefaultMessageSeverity if nothing is configured for that error category.

Test Plan

Tested manually to confirm configured categories display with the correct severity and that non-configured ones return with the default severity (ERROR).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 1320
Build 1320: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

prmshepherd updated this revision to Diff 23230.Jun 23 2014, 10:48 AM

prmshepherd retitled this revision from to Fix CPP Lint severity.

prmshepherd updated this object.

prmshepherd edited the test plan for this revision. (Show Details)

prmshepherd added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 10:48 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1320: Diff 23230.Jun 23 2014, 10:49 AM

Original patch changed default severity. Set the default severity to be warning

Harbormaster completed remote builds in B1327: Diff 23242.Jun 23 2014, 5:09 PM

Fix typo on default severity enum

Harbormaster completed remote builds in B1357: Diff 23304.Jun 24 2014, 7:56 AM

epriestley accepted this revision.May 19 2015, 2:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 2:57 PM

Closed by commit rARCddfdfce3f57e: Fix CPP Lint severity (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2015, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCpplintLinter.php

5 lines

Diff 23230

src/lint/linter/ArcanistCpplintLinter.php

Loading...