There are a bunch of unused variables in JavaScript files. These were identified with JSHint.
Details
Details
- Reviewers
- epriestley - chad 
- Group Reviewers
- Blessed Reviewers 
- Commits
- Restricted Diffusion Commit
 rPa0d63322b190: Remove unused JavaScript variables.
It's pretty hard to test this thoroughly... on inspection, it seems that everything should be okay (unless we are doing weird things with the JavaScript).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
- Lint Skipped 
- Unit
- Tests Skipped 
Event Timeline
Comment Actions
I sort of like the explicit parameters in callbacks, but I like getting rid of the unused variables more and don't care enough about them to make jshint raise the two issues separately. I can't think of any logical/behavioral errors that we could detect or prevent by retaining them, either.