Page MenuHomePhabricator
Differential D9674

Only lint files in the working copy with `arc lint --everything`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 12:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 9:51 PM
Unknown Object (File)
Sun, Feb 16, 8:05 PM
Unknown Object (File)
Sun, Feb 9, 1:49 PM
Unknown Object (File)
Sun, Feb 9, 1:49 PM
Unknown Object (File)
Sun, Feb 9, 1:49 PM
Unknown Object (File)
Sun, Feb 9, 1:49 PM
Unknown Object (File)
Jan 18 2025, 11:40 AM
Unknown Object (File)
Jan 17 2025, 5:17 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5442: Ignored files should automatically be excluded from linting
Commits
rARC4fd6c99a9331: Only lint files in the working copy with `arc lint --everything`.
Summary

Fixes T5442. arc lint --everything currently uses a FileFinder to discover paths for linting. A consequence of this is that files that are ignored or otherwise excluded from version control are linted.

Test Plan

Ran arc lint --everything in rPHU and noticed that I wasn't prompted to add a trailing newline to src/.phutil_module_cache.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23219.Jun 23 2014, 12:08 AM
joshuaspence retitled this revision from to Only lint files in the working copy with `arc lint --everything`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5442: Ignored files should automatically be excluded from linting.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 12:08 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1311: Diff 23219.Jun 23 2014, 12:09 AM
epriestley accepted this revision.Jun 23 2014, 12:20 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistLintWorkflow.php
220–221

This comment is probably no longer very useful.

This revision is now accepted and ready to land.Jun 23 2014, 12:20 AM
joshuaspence closed this revision.Jun 23 2014, 12:31 AM
joshuaspence updated this revision to Diff 23221.

Closed by commit rARC4fd6c99a9331 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
workflow/
16 lines

Diff 23221

View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility