Page MenuHomePhabricator
Differential D9674

Only lint files in the working copy with `arc lint --everything`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 12:08 AM.
Tags
None
Referenced Files
F14025968: D9674.diff
Thu, Nov 7, 9:34 PM
F14018321: D9674.diff
Tue, Nov 5, 8:24 AM
F14011930: D9674.id23221.diff
Fri, Nov 1, 6:07 AM
F14002300: D9674.id23221.diff
Fri, Oct 25, 5:35 PM
F13999526: D9674.diff
Thu, Oct 24, 3:22 PM
F13995535: D9674.id23221.diff
Wed, Oct 23, 1:40 PM
F13976664: D9674.diff
Fri, Oct 18, 3:14 PM
F13975523: D9674.id23219.diff
Fri, Oct 18, 10:30 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5442: Ignored files should automatically be excluded from linting
Commits
rARC4fd6c99a9331: Only lint files in the working copy with `arc lint --everything`.
Summary

Fixes T5442. arc lint --everything currently uses a FileFinder to discover paths for linting. A consequence of this is that files that are ignored or otherwise excluded from version control are linted.

Test Plan

Ran arc lint --everything in rPHU and noticed that I wasn't prompted to add a trailing newline to src/.phutil_module_cache.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23219.Jun 23 2014, 12:08 AM
joshuaspence retitled this revision from to Only lint files in the working copy with `arc lint --everything`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5442: Ignored files should automatically be excluded from linting.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 12:08 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1311: Diff 23219.Jun 23 2014, 12:09 AM
epriestley accepted this revision.Jun 23 2014, 12:20 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistLintWorkflow.php
220–221

This comment is probably no longer very useful.

This revision is now accepted and ready to land.Jun 23 2014, 12:20 AM
joshuaspence closed this revision.Jun 23 2014, 12:31 AM
joshuaspence updated this revision to Diff 23221.

Closed by commit rARC4fd6c99a9331 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
workflow/
16 lines

Diff 23221

View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility