Page MenuHomePhabricator
Differential D9631

CSS polish, Pholio
ClosedPublic
Actions

Authored by chad on Jun 19 2014, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 7:11 AM
Unknown Object (File)
Fri, Dec 20, 1:52 AM
Unknown Object (File)
Tue, Dec 17, 5:45 AM
Unknown Object (File)
Sun, Dec 15, 1:47 AM
Unknown Object (File)
Fri, Dec 13, 6:44 AM
Unknown Object (File)
Thu, Dec 12, 11:07 AM
Unknown Object (File)
Wed, Nov 27, 8:16 PM
Unknown Object (File)
Wed, Nov 27, 2:45 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPfa278fcb087d: CSS polish, Pholio
Summary

Minor things

  • Fades out comment icon on hover
  • Adds hover to inline comment images
  • moves mask position to just the image, and not the transparent border
Test Plan

Tested all of these items on various mocks

Diff Detail

Repository
rP Phabricator
Branch
precise-mask-css
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1242
Build 1242: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 23095.Jun 19 2014, 5:59 PM
chad retitled this revision from to CSS polish, Pholio.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 19 2014, 5:59 PM
chad added a comment.Jun 19 2014, 6:00 PM

Screen_Shot_2014-06-19_at_10.58.04_AM.png (271×307 px, 35 KB)

Harbormaster completed remote builds in B1242: Diff 23095.Jun 19 2014, 6:00 PM
epriestley accepted this revision.Jun 19 2014, 6:21 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/application/pholio/pholio.css
144–145

(These hover rules maybe have .device-desktop, IIRC the phone goes a little crazy sometimes with hover rules?)

This revision is now accepted and ready to land.Jun 19 2014, 6:21 PM
chad added inline comments.Jun 19 2014, 6:25 PM
webroot/rsrc/css/application/pholio/pholio.css
144–145

We don't seem to show any comment icons on mobile. JS? Can scope anyways.

chad closed this revision.Jun 19 2014, 6:28 PM
chad updated this revision to Diff 23097.

Closed by commit rPfa278fcb087d (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
src/
applications/
pholio/
view/
3 lines
webroot/
rsrc/
css/
application/
pholio/
21 lines
phui/
4 lines
js/
application/
pholio/
17 lines

Diff 23095

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/view/PholioTransactionView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/css/phui/phui-image-mask.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility