Page MenuHomePhabricator

Fix invalid submit_uri when creating dashboard panels
ClosedPublic

Authored by tobyhughes on Jun 19 2014, 10:29 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPbaf4d451aabb: Fix invalid submit_uri when creating dashboard panels
Summary

When creating dashboard panels, the submit_uri is invalid since the panel has not been saved to the database yet (and therefore doesn't have an ID). This resulted in a 404 when trying to submit the form to /dashboard/panel/edit//

Test Plan

Created a dashboard panel and the panel was created successfully

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

tobyhughes retitled this revision from to Fix invalid submit_uri when creating dashboard panels.
tobyhughes updated this object.
tobyhughes edited the test plan for this revision. (Show Details)
tobyhughes added a reviewer: epriestley.
epriestley accepted this revision.Jun 19 2014, 9:19 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jun 19 2014, 9:19 PM
epriestley closed this revision.Jun 19 2014, 9:20 PM
epriestley updated this revision to Diff 23103.

Closed by commit rPbaf4d451aabb (authored by @tobyhughes, committed by @epriestley).