Page MenuHomePhabricator

Fix invalid submit_uri when creating dashboard panels
ClosedPublic

Authored by tobyhughes on Jun 19 2014, 10:29 AM.
Tags
None
Referenced Files
F18786999: D9629.diff
Tue, Oct 14, 9:25 PM
F18786296: D9629.id.diff
Tue, Oct 14, 6:24 PM
F18782701: D9629.id23093.diff
Mon, Oct 13, 2:22 AM
F18777724: D9629.diff
Sat, Oct 11, 4:49 AM
F18734970: D9629.id.diff
Tue, Sep 30, 11:07 PM
F18657037: D9629.id23103.diff
Tue, Sep 23, 12:17 AM
F18111626: D9629.diff
Aug 12 2025, 11:13 AM
F18091517: D9629.id.diff
Aug 6 2025, 10:19 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPbaf4d451aabb: Fix invalid submit_uri when creating dashboard panels
Summary

When creating dashboard panels, the submit_uri is invalid since the panel has not been saved to the database yet (and therefore doesn't have an ID). This resulted in a 404 when trying to submit the form to /dashboard/panel/edit//

Test Plan

Created a dashboard panel and the panel was created successfully

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tobyhughes retitled this revision from to Fix invalid submit_uri when creating dashboard panels.
tobyhughes updated this object.
tobyhughes edited the test plan for this revision. (Show Details)
tobyhughes added a reviewer: epriestley.
This revision is now accepted and ready to land.Jun 19 2014, 9:19 PM
epriestley updated this revision to Diff 23103.

Closed by commit rPbaf4d451aabb (authored by @tobyhughes, committed by @epriestley).