Fix failing unit test.
ClosedPublic
Actions

Authored by joshuaspence on Jun 18 2014, 12:01 AM.

Details

Reviewers

hach-que
epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU50185a502e91: Fix failing unit test.

Summary

On PHP versions earlier than 5.4.0, \e is not a valid PHP escape character. Consequently, PhutilUTF8TestCase::testUTF8ConsoleStrlen will fail. Replace \e by its hexadecimal equivalent.

Test Plan

Ran unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23050.Jun 18 2014, 12:01 AM

joshuaspence retitled this revision from to Fix failing unit test..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, hach-que.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2014, 12:01 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1205: Diff 23050.Jun 18 2014, 12:03 AM

Confirmed this fixes the issue.

Maybe swap the \e in phutil_utf8_console_strlen() just for clarity? It must be getting interpreted consistently by PCRE, but it might be clearer to use an escape byte explicitly (e.g., no one will copy/paste it and run into this issue at some point in the fuutre).

This revision is now accepted and ready to land.Jun 18 2014, 12:12 AM

Closed by commit rPHU50185a502e91 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUTF8TestCase.php

4 lines

utf8.php

2 lines

Diff 23053

View Options

src/utils/tests/PhutilUTF8TestCase.php

View Options

Fix failing unit test.ClosedPublicActions