Page MenuHomePhabricator

Convert `./bin/storage status` to use `PhutilConsoleTable`.
ClosedPublic

Authored by joshuaspence on Jun 17 2014, 5:53 PM.
Tags
None
Referenced Files
F14027941: D9604.id23020.diff
Fri, Nov 8, 11:02 AM
Unknown Object (File)
Oct 1 2024, 4:59 PM
Unknown Object (File)
Sep 26 2024, 6:55 AM
Unknown Object (File)
Sep 19 2024, 1:27 PM
Unknown Object (File)
Sep 19 2024, 1:23 PM
Unknown Object (File)
Sep 19 2024, 1:20 PM
Unknown Object (File)
Sep 18 2024, 4:30 PM
Unknown Object (File)
Sep 15 2024, 7:24 PM
Subscribers

Details

Summary

Constructing tables manually just isn't fun.

Test Plan
./bin/storage status
phabricator:db.audit                                      Applied db   audit                                                                                       
phabricator:db.calendar                                   Applied db   calendar                                                                                    
phabricator:db.chatlog                                    Applied db   chatlog                                                                                     
phabricator:db.conduit                                    Applied db   conduit                                                                                     
phabricator:db.countdown                                  Applied db   countdown                                                                                   
phabricator:db.daemon                                     Applied db   daemon                                                                                      
phabricator:db.differential                               Applied db   differential                                                                                
phabricator:db.draft                                      Applied db   draft                                                                                       
phabricator:db.drydock                                    Applied db   drydock                                                                                     
phabricator:db.feed                                       Applied db   feed                                                                                        
phabricator:db.file                                       Applied db   file                                                                                        
phabricator:db.flag                                       Applied db   flag                                                                                        
phabricator:db.harbormaster                               Applied db   harbormaster
...

This probably isn't ready to land yet, we should fix PhutilConsoleTable to truncate columns which would otherwise cause overflow.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Convert `./bin/storage status` to use `PhutilConsoleTable`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

(We could likely also convert ./bin/storage probe, but the output format is not a conventional table)

epriestley edited edge metadata.

This probably isn't ready to land yet, we should fix PhutilConsoleTable to truncate columns which would otherwise cause overflow.

I think this is fine -- it's sort of bad to truncate the paths, and the non-truncation behavior is no worse than what we do today.

This revision is now accepted and ready to land.Jun 21 2014, 5:04 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 23164.

Closed by commit rPb7b045830307 (authored by @joshuaspence).