Page MenuHomePhabricator
Differential D9600

Make Dashboard tab panels editable by humans
ClosedPublic
Actions

Authored by epriestley on Jun 17 2014, 3:44 PM.
Tags
None
Referenced Files
F15470203: D9600.diff
Fri, Apr 4, 9:16 PM
F15436061: D9600.id23000.diff
Tue, Mar 25, 11:43 AM
F15431175: D9600.id.diff
Mon, Mar 24, 10:58 AM
F15427599: D9600.diff
Sun, Mar 23, 3:09 PM
F15425797: D9600.id23036.diff
Sun, Mar 23, 6:08 AM
F15425796: D9600.id23000.diff
Sun, Mar 23, 6:08 AM
F15424162: D9600.id23000.diff
Sat, Mar 22, 8:38 PM
F15409367: D9600.diff
Wed, Mar 19, 4:26 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5335: What should the UI for editing "tab" dashboard panels look like?
Commits
Restricted Diffusion Commit
rPdf2c015e7cff: Make Dashboard tab panels editable by humans
Summary

Fixes T5335. This is not pretty, but should reasonably let normal humans create tab panels.

Test Plan

See screenshot.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23000.Jun 17 2014, 3:44 PM
epriestley retitled this revision from to Make Dashboard tab panels editable by humans.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5335: What should the UI for editing "tab" dashboard panels look like?.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 17 2014, 3:44 PM
epriestley added a comment.Jun 17 2014, 3:44 PM

Not going to win any awards, but better than "JSON Config":

Screen_Shot_2014-06-17_at_8.42.13_AM.png (1×1 px, 157 KB)

Harbormaster completed remote builds in B1174: Diff 23000.Jun 17 2014, 3:45 PM
chad accepted this revision.Jun 17 2014, 4:02 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2014, 4:02 PM
epriestley closed this revision.Jun 17 2014, 10:33 PM
epriestley updated this revision to Diff 23036.

Closed by commit rPdf2c015e7cff (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
dashboard/
customfield/
71 lines
paneltype/
14 lines

Diff 23036

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...
Phabricator · Built by Phacility