Page MenuHomePhabricator
Differential D9597

Ignore colors and formatting when determining string length.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 7:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 1:38 PM
Unknown Object (File)
Sat, Aug 31, 5:10 AM
Unknown Object (File)
Sat, Aug 31, 5:10 AM
Unknown Object (File)
Sat, Aug 31, 5:10 AM
Unknown Object (File)
Sat, Aug 31, 5:10 AM
Unknown Object (File)
Sat, Aug 31, 5:01 AM
Unknown Object (File)
Thu, Aug 29, 12:58 AM
Unknown Object (File)
Tue, Aug 27, 1:50 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU68f970cae19f: Ignore colors and formatting when determining string length.
Summary

When calculating the length of a string with phutil_utf8_console_strlen, escape codes shouldn't contribute any width to the string.

This change allows for the widths of a PhutilConsoleTable table to be determined correctly when using rows containing formatting and/or colors.

Test Plan

Before

Before (99×495 px, 10 KB)

After

After (97×372 px, 10 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22989.Jun 17 2014, 7:40 AM
joshuaspence retitled this revision from to Ignore colors and formatting when determining string length..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 7:40 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1170: Diff 22989.Jun 17 2014, 7:41 AM
epriestley accepted this revision.Jun 17 2014, 11:20 AM
epriestley edited edge metadata.

Consider adding a unit test or two, there should already be a test case.

Does /s do anything in this case? There's no . in the regexp. (For that matter, I don't see a way for U to ever affect behavior.)

This revision is now accepted and ready to land.Jun 17 2014, 11:20 AM
joshuaspence updated this revision to Diff 23001.Jun 17 2014, 3:58 PM
joshuaspence edited edge metadata.
  • Remove unnecessary sU from regex.
  • Add unit tests.
Harbormaster completed remote builds in B1175: Diff 23001.Jun 17 2014, 3:59 PM
joshuaspence closed this revision.Jun 17 2014, 3:59 PM
joshuaspence updated this revision to Diff 23002.

Closed by commit rPHU68f970cae19f (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
utils/
__tests__/
4 lines
3 lines

Diff 23002

View Options

src/utils/__tests__/PhutilUTF8TestCase.php

Loading...
View Options

src/utils/utf8.php

Loading...
Phabricator · Built by Phacility