Differential D9573

Fix some off-by-one issues when drag-and-dropping dashboard panels
ClosedPublic
Actions

Authored by epriestley on Jun 16 2014, 3:28 PM.

Details

Reviewers

chad

Maniphest Tasks

T5321: Drag and drop placement unpredictable on Dashboards

Commits

Restricted Diffusion Commit
rP5f52f1f82cac: Fix some off-by-one issues when drag-and-dropping dashboard panels

Summary

Fixes T5321. There were a couple of off-by-one issues here which could result in inserts into the wrong position.

Test Plan

Dragged panels to the top, bottom, and first position of columns.
Dragged panels from one column to another.
Reloaded the page after drags, things stayed where I put them.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22940.Jun 16 2014, 3:28 PM

epriestley retitled this revision from to Fix some off-by-one issues when drag-and-dropping dashboard panels.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5321: Drag and drop placement unpredictable on Dashboards.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 16 2014, 3:28 PM

Harbormaster completed remote builds in B1141: Diff 22940.Jun 16 2014, 3:29 PM

chad accepted this revision.Jun 16 2014, 3:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2014, 3:41 PM

Closed by commit rP5f52f1f82cac (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardMovePanelController.php

25 lines

Diff 22942

View Options

src/applications/dashboard/controller/PhabricatorDashboardMovePanelController.php

Fix some off-by-one issues when drag-and-dropping dashboard panelsClosedPublicActions