Page MenuHomePhabricator

Add constants and class methods to `php_compat_info.json`.
ClosedPublic

Authored by joshuaspence on Jun 16 2014, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:04 PM
Unknown Object (File)
Fri, Dec 20, 10:22 AM
Unknown Object (File)
Fri, Dec 20, 10:22 AM
Unknown Object (File)
Fri, Dec 20, 10:21 AM
Unknown Object (File)
Tue, Dec 17, 6:53 AM
Unknown Object (File)
Tue, Dec 17, 3:03 AM
Unknown Object (File)
Sun, Dec 15, 7:31 AM
Unknown Object (File)
Sun, Dec 15, 5:38 AM
Subscribers

Details

Summary

Allows the ArcanistXHPASTLinter to determine whether constants can be used, based on the target PHP version. Also added class methods to the compatibility information, although this isn't used yet (it is small anyway).

Test Plan

Created a test file that contained the JSON_PRETTY_PRINT constant. Verified that a linter error was raised.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Add constants and class methods to `php_compat_info.json`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2014, 2:56 PM