Page MenuHomePhabricator
Differential D9557

Move infrastructure tests up one directory.
ClosedPublic
Actions

Authored by joshuaspence on Jun 15 2014, 7:31 PM.
Tags
None
Referenced Files
F14442930: D9557.id.diff
Thu, Dec 26, 9:11 AM
F14432548: D9557.diff
Wed, Dec 25, 7:45 PM
Unknown Object (File)
Tue, Dec 24, 9:22 AM
Unknown Object (File)
Thu, Dec 12, 12:46 AM
Unknown Object (File)
Tue, Dec 3, 5:22 PM
Unknown Object (File)
Tue, Dec 3, 5:21 PM
Unknown Object (File)
Tue, Dec 3, 5:21 PM
Unknown Object (File)
Tue, Dec 3, 5:09 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUb62b10c046be: Move infrastructure tests up one directory.
Summary

Sometimes, the PhutilInfrastructureTestCase would fail, but we don't run it with arc unit because of the directory structure. See D9556 for an example.

Test Plan

Ran arc unit --everything and verified that PhutilInfrastructureTestCase was executed.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22910.Jun 15 2014, 7:31 PM
joshuaspence retitled this revision from to Move infrastructure tests up one directory..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 15 2014, 7:31 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1123: Diff 22910.Jun 15 2014, 7:32 PM
epriestley accepted this revision.Jun 15 2014, 7:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 7:33 PM
joshuaspence closed this revision.Jun 15 2014, 7:34 PM
joshuaspence updated this revision to Diff 22911.

Closed by commit rPHUb62b10c046be (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
2 lines
__tests__/
infrastructure/
__tests__/
infrastructure/
__tests__/

Diff 22911

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/__tests__/PhutilInfrastructureTestCase.php

Loading...
View Options

src/infrastructure/__tests__/PhutilInfrastructureTestCase.php

Loading...
Phabricator · Built by Phacility