Page MenuHomePhabricator
Differential D9544

Use comment icon for Pholio Inline Comments
ClosedPublic
Actions

Authored by chad on Jun 15 2014, 3:57 AM.
Tags
None
Referenced Files
F13325974: D9544.id22870.diff
Sat, Jun 15, 2:27 AM
F13325971: D9544.id22871.diff
Sat, Jun 15, 2:27 AM
F13301754: D9544.id22871.diff
Sat, Jun 8, 3:21 AM
F13301753: D9544.id22870.diff
Sat, Jun 8, 3:21 AM
F13301695: D9544.id.diff
Sat, Jun 8, 2:55 AM
F13301634: D9544.diff
Sat, Jun 8, 2:21 AM
F13288200: D9544.diff
Tue, Jun 4, 9:57 AM
F13276206: D9544.diff
Fri, May 31, 5:40 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP2bbafcc924ec: Use comment icon for Pholio Inline Comments
Summary

Uses FontAwesome CSS icons

Test Plan

Check draft and normal states. Click.

undefined (295×471 px, 187 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22870.Jun 15 2014, 3:57 AM
chad retitled this revision from to Use comment icon for Pholio Inline Comments.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 15 2014, 3:57 AM
chad edited the test plan for this revision. (Show Details)Jun 15 2014, 3:57 AM
Harbormaster completed remote builds in B1103: Diff 22870.Jun 15 2014, 3:58 AM
epriestley accepted this revision.Jun 15 2014, 3:59 AM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/application/pholio/pholio.css
148

(Why is only this one right-aligned?)

This revision is now accepted and ready to land.Jun 15 2014, 3:59 AM
chad added inline comments.Jun 15 2014, 4:00 AM
webroot/rsrc/css/application/pholio/pholio.css
148

cmd-z failed me

chad closed this revision.Jun 15 2014, 4:01 AM
chad updated this revision to Diff 22871.

Closed by commit rP2bbafcc924ec (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
css/
application/
pholio/
14 lines
js/
application/
pholio/
4 lines

Diff 22871

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility