Page MenuHomePhabricator

Turn thumbs into a history grid thing
ClosedPublic

Authored by epriestley on Jun 15 2014, 3:48 AM.
Tags
None
Referenced Files
F13187307: D9543.diff
Sat, May 11, 4:27 AM
Unknown Object (File)
Tue, May 7, 6:32 AM
Unknown Object (File)
Fri, May 3, 5:48 AM
Unknown Object (File)
Mon, Apr 29, 4:27 PM
Unknown Object (File)
Wed, Apr 24, 10:32 PM
Unknown Object (File)
Wed, Apr 24, 7:03 AM
Unknown Object (File)
Tue, Apr 16, 2:57 AM
Unknown Object (File)
Apr 7 2024, 3:48 PM
Subscribers

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP7ce8a1f437ae: Turn thumbs into a history grid thing
Summary

This could probably use some refinement (and, like, explanatory text, and stronger cues about what rows and columns mean) but feels fairly good to me, at least on test data.

I didn't do any scrolling for now since we have to do full height on mobile anyway I think. I did swap it so the newer ones are on top.

Left/right navigate you among current images only, but you can click any thumb to review history.

Removed history view since it's no longer useful.

Some things that would probably help:

  • Some kind of header explaining what this is ("Mock History" or something).
  • Stronger visual cue that columns are related by being the same image.
  • Clearer cues about obsolete/deleted images (e.g., on the stage itself?)
  • Maybe general tweaks.
  • Maybe a placeholder (like a grey "X") for images which have been deleted.

(I'm planning to add comment counts too, which I think will be pretty useful, but that felt good to put in another diff.)

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Turn thumbs into a history grid thing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This test one is huge, but I think it's way more complex than anything we'll normally see:

Screen_Shot_2014-06-14_at_8.45.54_PM.png (651×1 px, 74 KB)

chad edited edge metadata.

Is "Current" the top set here? I'm assuming, since they are fully opaque. Then the other columns have been removed from the set? I already have a rough idea what to do visually to pump this up based on your napkin sketch.

This revision is now accepted and ready to land.Jun 15 2014, 4:06 AM

Yep:

  • Top is active/recent.
  • The fully-opaque ones are the current set.
  • The history of each image is in the column below it, oldest at the bottom.
  • If an image was deleted, it just has history (no current thumb).

Some older mocks will have funky data once this is pushed because of the bug fixed in D9541, but anything after that should make sense.

epriestley updated this revision to Diff 22874.

Closed by commit rP7ce8a1f437ae (authored by @epriestley).