This greatly simplifies inline comments while retaining their functionality. This is probably not where we want to end up, but will let us figure out what we're doing with the stage without worrying about inlines.
Details
Details
- Reviewers
chad - Commits
- Restricted Diffusion Commit
rP942f50489357: Remove inline gutter in Pholio
See screenshots.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- inlines2
- Lint
Lint Passed Severity Location Code Message Advice src/applications/pholio/controller/PholioInlineController.php:57 XHP16 TODO Comment - Unit
No Test Coverage - Build Status
Buildable 1095 Build 1095: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Adding an inline is now just a modal dialog:
Draft inline:
Inlines just pop up in a modal dialog:
This is probably not where we want to be in the long run, but it might reasonably be an improvement over what we have now.