Page MenuHomePhabricator
Differential D9536

Increase finesse of inline comments in Pholio
ClosedPublic
Actions

Authored by epriestley on Jun 14 2014, 11:52 PM.
Tags
None
Referenced Files
F14852184: D9536.diff
Tue, Feb 4, 10:52 PM
Unknown Object (File)
Thu, Jan 30, 11:00 PM
Unknown Object (File)
Fri, Jan 24, 11:16 PM
Unknown Object (File)
Fri, Jan 17, 10:39 PM
Unknown Object (File)
Fri, Jan 17, 6:55 PM
Unknown Object (File)
Sun, Jan 12, 7:23 AM
Unknown Object (File)
Sun, Jan 12, 4:09 AM
Unknown Object (File)
Mon, Jan 6, 2:36 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPfc2c3a5ca883: Increase finesse of inline comments in Pholio
Summary
  • Hide inline areas on mobile, and when the mouse cursor is not on the stage.
  • Show small icon markers instead of areas.
  • Yellow icons show draft comments; pink icons show final comments.
Test Plan

Screen_Shot_2014-06-14_at_4.51.35_PM.png (444×710 px, 222 KB)

Diff Detail

Repository
rP Phabricator
Branch
inlines
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1093
Build 1093: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22855.Jun 14 2014, 11:52 PM
epriestley retitled this revision from to Increase finesse of inline comments in Pholio.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 14 2014, 11:52 PM
Harbormaster completed remote builds in B1093: Diff 22855.Jun 14 2014, 11:54 PM
chad accepted this revision.Jun 15 2014, 12:06 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 12:06 AM
epriestley closed this revision.Jun 15 2014, 1:40 AM
epriestley updated this revision to Diff 22860.

Closed by commit rPfc2c3a5ca883 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
css/
application/
pholio/
48 lines
js/
application/
pholio/
60 lines

Diff 22855

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility