Differential D9536

Increase finesse of inline comments in Pholio
ClosedPublic
Actions

Authored by epriestley on Jun 14 2014, 11:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 4, 4:46 AM

	Unknown Object (File)
	Mon, Aug 26, 8:00 PM

	Unknown Object (File)
	Sun, Aug 25, 8:20 PM

	Unknown Object (File)
	Sun, Aug 18, 3:26 PM

	Unknown Object (File)
	Sat, Aug 17, 3:23 AM

	Unknown Object (File)
	Thu, Aug 15, 9:17 PM

	Unknown Object (File)
	Aug 9 2024, 5:19 AM

	Unknown Object (File)
	Aug 5 2024, 5:49 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPfc2c3a5ca883: Increase finesse of inline comments in Pholio

Summary

Hide inline areas on mobile, and when the mouse cursor is not on the stage.
Show small icon markers instead of areas.
Yellow icons show draft comments; pink icons show final comments.

Test Plan

Screen_Shot_2014-06-14_at_4.51.35_PM.png (444×710 px, 222 KB)

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22855.Jun 14 2014, 11:52 PM

epriestley retitled this revision from to Increase finesse of inline comments in Pholio.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 14 2014, 11:52 PM

Harbormaster completed remote builds in B1093: Diff 22855.Jun 14 2014, 11:54 PM

chad accepted this revision.Jun 15 2014, 12:06 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 12:06 AM

Closed by commit rPfc2c3a5ca883 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

38 lines

webroot/

rsrc/

css/

application/

pholio/

47 lines

js/

application/

pholio/

behavior-pholio-mock-view.js

60 lines

Diff 22860

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/pholio/pholio.css

Loading...

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...