Page MenuHomePhabricator
Differential D9536

Increase finesse of inline comments in Pholio
ClosedPublic
Actions

Authored by epriestley on Jun 14 2014, 11:52 PM.
Tags
None
Referenced Files
F14046535: D9536.diff
Wed, Nov 13, 9:45 PM
F14036007: D9536.diff
Sun, Nov 10, 8:12 AM
F14007240: D9536.diff
Tue, Oct 29, 2:14 AM
F13977679: D9536.diff
Oct 18 2024, 7:33 PM
F13956987: D9536.id22860.diff
Oct 14 2024, 7:48 AM
Unknown Object (File)
Oct 4 2024, 2:07 PM
Unknown Object (File)
Oct 1 2024, 7:25 AM
Unknown Object (File)
Sep 30 2024, 11:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPfc2c3a5ca883: Increase finesse of inline comments in Pholio
Summary
  • Hide inline areas on mobile, and when the mouse cursor is not on the stage.
  • Show small icon markers instead of areas.
  • Yellow icons show draft comments; pink icons show final comments.
Test Plan

Screen_Shot_2014-06-14_at_4.51.35_PM.png (444×710 px, 222 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22855.Jun 14 2014, 11:52 PM
epriestley retitled this revision from to Increase finesse of inline comments in Pholio.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 14 2014, 11:52 PM
Harbormaster completed remote builds in B1093: Diff 22855.Jun 14 2014, 11:54 PM
chad accepted this revision.Jun 15 2014, 12:06 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 12:06 AM
epriestley closed this revision.Jun 15 2014, 1:40 AM
epriestley updated this revision to Diff 22860.

Closed by commit rPfc2c3a5ca883 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
css/
application/
pholio/
47 lines
js/
application/
pholio/
60 lines

Diff 22860

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility