Differential D9518

make "Land to..." button call diffusion.looksoon
ClosedPublic
Actions

Authored by avivey on Jun 13 2014, 6:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP78c2d5858699: make "Land to..." button call diffusion.looksoon

Summary

add looksoon call after every attempt at landing.

This includes failed attempts, to elevate "not a fast-forward" issues, although there are probably smarter things to be done about that.

Test Plan

Land, look at logs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avivey updated this revision to Diff 22815.Jun 13 2014, 6:38 PM

avivey retitled this revision from to make "Land to..." button call diffusion.looksoon.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2014, 6:38 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

avivey planned changes to this revision.Jun 13 2014, 6:38 PM

Harbormaster completed remote builds in B1065: Diff 22815.Jun 13 2014, 6:39 PM

avivey requested a review of this revision.Jun 22 2014, 7:28 PM

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey edited edge metadata.

epriestley accepted this revision.Jun 22 2014, 7:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2014, 7:29 PM

Closed by commit rP78c2d5858699 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionLandController.php

9 lines

Diff 23208

View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

make "Land to..." button call diffusion.looksoonClosedPublicActions