Page MenuHomePhabricator
Differential D9515

[Discussion] Remove ObjItem gradient
ClosedPublic
Actions

Authored by chad on Jun 13 2014, 4:32 PM.
Tags
None
Referenced Files
F15485912: D9515.id22810.diff
Thu, Apr 10, 3:31 AM
F15484974: D9515.id22808.diff
Wed, Apr 9, 9:09 PM
F15484798: D9515.id24540.diff
Wed, Apr 9, 8:11 PM
F15484320: D9515.id.diff
Wed, Apr 9, 5:41 PM
F15482291: D9515.id22809.diff
Wed, Apr 9, 4:11 AM
F15478912: D9515.diff
Tue, Apr 8, 3:50 AM
F15470142: D9515.id22808.diff
Fri, Apr 4, 8:31 PM
F15465509: D9515.diff
Wed, Apr 2, 7:44 PM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T5325: Pastes look janky as cards
Commits
Restricted Diffusion Commit
rPcda397da9cf3: [Discussion] Remove ObjItem gradient
Summary

Just wanted to play with this, removes the gradient 'cards' for a flat design.

Test Plan

Tested various apps, workboards

undefined (330×450 px, 53 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22808.Jun 13 2014, 4:32 PM
chad retitled this revision from to [Discussion] Remove ObjItem gradient.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 13 2014, 4:32 PM
chad edited the test plan for this revision. (Show Details)Jun 13 2014, 4:33 PM
chad added a subscriber: hach-que.
Harbormaster completed remote builds in B1060: Diff 22808.Jun 13 2014, 4:34 PM
epriestley edited edge metadata.Jun 13 2014, 4:38 PM

I like it, let me poke around a bit locally with it and see how it feels.

epriestley added a comment.Jun 13 2014, 4:41 PM

The border color or emphasis could maybe be a little stronger on workboards -- visually, the card edge is lost in the background a little bit here:

Screen_Shot_2014-06-13_at_9.39.43_AM.png (164×325 px, 13 KB)

The border on Paste could also probably be backed out if we adopt this:

Screen_Shot_2014-06-13_at_9.40.28_AM.png (72×1 px, 12 KB)

Everything else looks good to me, though.

chad updated this revision to Diff 22809.Jun 13 2014, 4:52 PM
chad edited edge metadata.
  • Slighly less "backdrop" (Useful for full-height columns too)
Harbormaster completed remote builds in B1061: Diff 22809.Jun 13 2014, 4:53 PM
chad updated this revision to Diff 22810.Jun 13 2014, 4:53 PM
  • Tweak min-height of columns
Harbormaster completed remote builds in B1062: Diff 22810.Jun 13 2014, 4:55 PM
epriestley accepted this revision.Jun 16 2014, 6:40 PM
epriestley edited edge metadata.

Not sure if you want to move forward with this, but it seems reasonable to me if you've convinced yourself you like it. :)

This revision is now accepted and ready to land.Jun 16 2014, 6:40 PM
chad added a comment.Jun 16 2014, 6:48 PM

Not really sure, i'll live with it a bit later this week.

chad closed this revision.Aug 8 2014, 9:08 PM
chad updated this revision to Diff 24540.

Closed by commit rPcda397da9cf3 (authored by @chad).

chad added a task: T5325: Pastes look janky as cards.Aug 8 2014, 9:09 PM

shipitslow

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
infrastructure/
celerity/
2 lines
webroot/
rsrc/
css/
phui/
5 lines
14 lines

Diff 24540

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceTransformer.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workpanel-view.css

Loading...
Phabricator · Built by Phacility