Page MenuHomePhabricator
Differential D9514

Add setDisabled to pinboard view
ClosedPublic
Actions

Authored by chad on Jun 13 2014, 3:57 PM.
Tags
None
Referenced Files
F13205568: D9514.diff
Wed, May 15, 2:09 AM
F13201376: D9514.id22802.diff
Tue, May 14, 11:38 AM
F13201373: D9514.id22799.diff
Tue, May 14, 11:38 AM
F13189859: D9514.diff
Sat, May 11, 6:30 AM
Unknown Object (File)
Tue, May 7, 10:04 AM
Unknown Object (File)
Mon, May 6, 10:32 AM
Unknown Object (File)
Fri, May 3, 10:16 AM
Unknown Object (File)
Thu, Apr 25, 3:17 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
lpriestley
Maniphest Tasks
T5074: Add `setDisabled(true)` to PHUIPinboardItemView
Commits
Restricted Diffusion Commit
rP8426d1d2ab47: Add setDisabled to pinboard view
Summary

Adds setDisabled state to PHUIPinboardItemView, implements in Pholio, Macro

Test Plan

Pholio, Macro, disabled and closed items.

undefined (612×921 px, 208 KB)

undefined (641×920 px, 343 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 22799.Jun 13 2014, 3:57 PM
chad retitled this revision from to Add setDisabled to pinboard view.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, lpriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 13 2014, 3:57 PM
chad edited the test plan for this revision. (Show Details)Jun 13 2014, 3:58 PM
Harbormaster completed remote builds in B1053: Diff 22799.Jun 13 2014, 3:59 PM
chad added a task: T5074: Add `setDisabled(true)` to PHUIPinboardItemView.Jun 13 2014, 4:00 PM
epriestley accepted this revision.Jun 13 2014, 4:03 PM
epriestley edited edge metadata.

Consider removing the header text now? I don't think it's necessary any more (and it's ambiguous given that a mock can be called [Disabled] ...).

This revision is now accepted and ready to land.Jun 13 2014, 4:03 PM
chad added a comment.Jun 13 2014, 4:05 PM

what about an icon instead? or strikethrough of the title?

epriestley added a comment.Jun 13 2014, 4:10 PM

Strikethrough is probably most consistent.

chad closed this revision.Jun 13 2014, 4:14 PM
chad updated this revision to Diff 22802.

Closed by commit rP8426d1d2ab47 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
macro/
query/
8 lines
pholio/
query/
5 lines
view/
phui/
21 lines
webroot/
rsrc/
css/
phui/
10 lines

Diff 22802

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/view/phui/PHUIPinboardItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-pinboard-view.css

Loading...
Phabricator · Built by Phacility