Paths

Table of Contentst

Fix wording of 'bin/remove' prompt for repositories
ClosedPublic
Actions

Authored by epriestley on Jun 13 2014, 12:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 5:27 PM

	Unknown Object (File)
	Fri, Dec 13, 11:17 PM

	Unknown Object (File)
	Fri, Dec 13, 8:09 AM

	Unknown Object (File)
	Wed, Dec 11, 12:09 PM

	Unknown Object (File)
	Tue, Dec 10, 4:18 AM

	Unknown Object (File)
	Mon, Dec 2, 6:59 PM

	Unknown Object (File)
	Sat, Nov 30, 2:40 AM

	Unknown Object (File)
	Sat, Nov 30, 2:40 AM

View All Files

Subscribers

epriestley

Details

Reviewers

putnam
chad

Commits

Restricted Diffusion Commit
rP993b73596adf: Fix wording of 'bin/remove' prompt for repositories

Summary

This UI recommends bin/remove destroy X, but should recommend bin/remove destroy rX (with r), because the remove script now takes any object monogram. The older script was repository-specific, so it only took the callsign.

Test Plan

Screen_Shot_2014-06-13_at_5.30.24_AM.png (247×603 px, 26 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22792.Jun 13 2014, 12:30 PM

epriestley retitled this revision from to Fix wording of 'bin/remove' prompt for repositories.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: putnam, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 13 2014, 12:30 PM

Harbormaster completed remote builds in B1051: Diff 22792.Jun 13 2014, 12:31 PM

chad accepted this revision.Jun 13 2014, 2:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2014, 2:03 PM

Closed by commit rP993b73596adf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryEditDeleteController.php

4 lines

Diff 22795

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditDeleteController.php

Fix wording of 'bin/remove' prompt for repositoriesClosedPublicActions